-
Notifications
You must be signed in to change notification settings - Fork 9
Pro backend request/response glue code #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Doy-lee
wants to merge
121
commits into
session-foundation:dev
Choose a base branch
from
Doy-lee:doyle-pro-backend-polish
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pro backend request/response glue code #64
Doy-lee
wants to merge
121
commits into
session-foundation:dev
from
Doy-lee:doyle-pro-backend-polish
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
410f0e7
to
a83ab26
Compare
745e4ca
to
7bf64c8
Compare
This simplifies the API and minimises the API surface with code interacting with it since the public key is already bundled with the secret. - Add helper function to derive keys from the original seed - Use _hex_u literals to simplify test construction code
…literal Ensure that the websocket request has dummy fields set which is required for iOS.
f31c634
to
79f27fc
Compare
0f8dbd1
to
158ecad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes ontop of #63 only need to review the delta between the two.
--
The commits here are a polish pass over the draft code that was dumped into
src/pro.cpp
. That file has been renamed tosrc/pro_backend.cpp
. The role of this file now is to interop with the pro backend and adds a bunch of functions to construct the necessary HTTP POST payloads to send off to a Session Pro Backend to do one of the following operations:Additionally for each payment provider, libsession exposes the various platform specific URLs to centralise those strings into the same repository, as per:
The general usage pattern for the request and response code available in
pro_backend.{hpp,h}